Issue 4883001: NaCl base bringup....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4883001: NaCl base bringup.... (Closed)

Created:
10 years, 1 month ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org, eseidel

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

NaCl base bringup. Native client uses the GLIBC style of strerror_r but does not define __GLIBC__. It's possible the right thing to do is for the native client toolchain to define GLIBC, but the path of least resistance seems to be to adjust our conditionals in this file to understand NaCl. Original patch by Eric Seidel. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65961

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	base/safe_strerror_posix.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages