Issue 4882001: Return a speed of 0 if a download is paused from DownloadItem, instead of checking when rendering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4882001: Return a speed of 0 if a download is paused from DownloadItem, instead of checking when rendering. (Closed)

Created:
10 years, 1 month ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/download

Visibility:
Public.

Description

Return a speed of 0 if a download is paused from DownloadItem, instead of checking when rendering. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66102

Patch Set 1 #

Patch Set 2 : Code review #

Total comments: 1

Patch Set 3 : Code review fix #

Created: 10 years, 1 month ago

		Unified diffs	Side-by-side diffs	Stats (+6 lines, -11 lines)
	M	chrome/browser/download/download_item.cc	View	1 chunk	+2 lines, -0 lines	0 comments
	M	chrome/browser/download/download_util.cc	View	2 chunks	+4 lines, -11 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

10 years, 1 month ago (2010-11-12 09:18:00 UTC) #2

LGTM with a comment. Thank you!

http://codereview.chromium.org/4882001/diff/2001/chrome/browser/download/down...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/4882001/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:568: amount_units =
GetByteDisplayUnits(download->CurrentSpeed());
nit: Can you store the value of CurrentSpeed on a local variable to avoid
calling it twice?

Expand Messages | Collapse Messages