Issue 4880002: Add a virtual destructor to SimpleWebMimeRegistryImpl so that child class des...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4880002: Add a virtual destructor to SimpleWebMimeRegistryImpl so that child class des... (Closed)

Created:
10 years, 1 month ago by Marshall

Modified:
9 years, 7 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Add a virtual destructor to SimpleWebMimeRegistryImpl so that child class destructors get called correctly. BUG=62828 TEST=No memory leak in TestShellWebMimeRegistryImpl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65967

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	webkit/glue/simple_webmimeregistry_impl.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Timur Iskhodzhanov

10 years, 1 month ago (2010-11-12 18:54:36 UTC) #2

LGTM, thanks!
For the stats, please add Valgrind label to bug 62828 =)