Issue 4879001: Extend simple_file_system to use SandboxedFileSystemOperation

Issue 4879001: Extend simple_file_system to use SandboxedFileSystemOperation (Closed)

Created:
10 years, 1 month ago by kinuko

Modified:
9 years, 7 months ago

Reviewers:
michaeln, ericu

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Extend simple_file_system to use SandboxedFileSystemOperation so that most of the code paths that run in chromium can be tested in test_shell. Also removed SandboxedFileSystemContext::CheckIfFilePathIsSafe that is not used at all. BUG=60243 TEST=fast/filesystem Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67158

Patch Set 1 : '' #

Total comments: 3

Patch Set 2 : replaced /w DCHECK #

Patch Set 3 : introduced WeakPtr not to fire WebFileSystemCallbacks #

Total comments: 1

Patch Set 4 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -96 lines)			Patch
M	webkit/fileapi/sandboxed_file_system_operation.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/fileapi/sandboxed_file_system_operation.cc	View		2 chunks	+4 lines, -13 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	1 2	2 chunks	+6 lines, -12 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.h	View	1 2	2 chunks	+27 lines, -9 lines	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.cc	View	1 2 3	4 chunks	+107 lines, -34 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.h	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 2	2 chunks	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

michaeln

I like the encapsulation. http://codereview.chromium.org/4879001/diff/4001/webkit/tools/test_shell/simple_file_system.cc File webkit/tools/test_shell/simple_file_system.cc (right): http://codereview.chromium.org/4879001/diff/4001/webkit/tools/test_shell/simple_file_system.cc#newcode114 webkit/tools/test_shell/simple_file_system.cc:114: // (which in turn deletes ...

10 years, 1 month ago (2010-11-13 00:16:42 UTC) #1

kinuko

http://codereview.chromium.org/4879001/diff/4001/webkit/tools/test_shell/simple_file_system.cc File webkit/tools/test_shell/simple_file_system.cc (right): http://codereview.chromium.org/4879001/diff/4001/webkit/tools/test_shell/simple_file_system.cc#newcode114 webkit/tools/test_shell/simple_file_system.cc:114: // (which in turn deletes this dispatcher instance). On ...

10 years, 1 month ago (2010-11-13 00:38:14 UTC) #2

kinuko

Added the DCHECK. Also made the callback dispatcher hold WeakPtr of SimpleFileSystem, as this patch ...

10 years, 1 month ago (2010-11-19 20:44:38 UTC) #4

ericu

10 years, 1 month ago (2010-11-23 02:09:51 UTC) #5

http://codereview.chromium.org/4879001/diff/15001/webkit/tools/test_shell/sim...
File webkit/tools/test_shell/simple_file_system.cc (right):

http://codereview.chromium.org/4879001/diff/15001/webkit/tools/test_shell/sim...
webkit/tools/test_shell/simple_file_system.cc:71: if (file_system_) {
As discussed, change these ifs to DCHECKs, and you're good to go.

Expand Messages | Collapse Messages