Chromium Code Reviews

Issue 4876001: [Chrome OS] Move dependency on cros.git into main DEPS file (Closed)

Created:
10 years, 1 month ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews
Visibility:
Public.

Description

[Chrome OS] Move dependency on cros.git into main DEPS file Instead of depending on cros_deps (via a special .gclient rule) to pull in a special DEPS file that expresses the CrOS dependency on cros.git, just put that dependency in the main DEPS file. We had initially avoided this because we didn't want to force all the Chrome devs on Linux to need to install git; now it seems like most of the devs that work on Chrome Linux use git already. BUG=chromium-os:8859 TEST=do a clean sync of the source tree, after taking the cros_deps clause out of your .gclient file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66126

Patch Set 1 #

Patch Set 2 : remove debugging output #

Unified diffs Side-by-side diffs Stats (+3 lines, -1 line)
M DEPS View 1 chunk +3 lines, -1 line 0 comments

Messages

Total messages: 2 (0 generated)
Chris Masone
10 years, 1 month ago (2010-11-12 05:33:26 UTC) #1
DaveMoore
10 years, 1 month ago (2010-11-12 18:22:22 UTC) #2
LGTM

Powered by Google App Engine