Benchmark tool for GPU-accelerated video rendering

media/tools/shader_bench/window.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_TOOLS_SHADER_BENCH_WINDOW_H_
+#define MEDIA_TOOLS_SHADER_BENCH_WINDOW_H_
+
+#include "base/scoped_ptr.h"
+#include "base/task.h"
+#include "gfx/native_widget_types.h"
+#include "media/tools/shader_bench/painter.h"
+
+namespace media {
+
+class Window {

[tfarina, 2010/11/26 15:38:16]

This implementation is very similar to gpu/demos/framework/window.h

Should should they be shared somehow?

[vrk (LEFT CHROMIUM), 2010/11/29 18:14:41]

In a word, yes :) But because they are used for pretty different purposes (one
being demos, the other being benchmarks), they are just different enough that
sharing the two classes requires a bit of refactoring. Both the demos and
shader_bench are stand-alone apps not used by chrome, so I would rather defer
that task to another cl if possible!

[tfarina, 2010/11/29 18:28:36]

Sure :)

That is what I was suggesting, it was more like a note for further reference. 
Maybe file a bug for this?

+ public:
+  Window(int width, int height);
+  virtual void Start(int limit, Task* done_task, Painter* painter);

[tfarina, 2010/11/26 15:38:16]

Make this 3 virtual methods pure if they are always required by the
implementations?

[vrk (LEFT CHROMIUM), 2010/11/29 18:14:41]

The platform-dependent Window implementations are not actually subclasses of
Window, so pure virtual methods don't make sense for this. Either
window_linux.cc or window_win.cc is included depending on what platform this is
being built on, so either the linux or windows definitions will be linked with
the Window header file.

[tfarina, 2010/11/29 18:28:36]

Ah, yeah. We are noting doing inheritance here :( 

Like:

class WindowWin : public Window {
...
};

class WindowGtk: public Window {
...
};

I find this more intuitive though. Hence my mistake.
Yeah, that is an option, but not often used by chrome.

+  virtual void OnPaint();
+  virtual void MainLoop();
+  gfx::NativeWindow CreateNativeWindow(int width, int height);
+  gfx::PluginWindowHandle PluginWindow();
+
+ protected:
+  Task* done_task_;
+  Painter* painter_;
+  int limit_;
+  int count_;
+  bool running_;
+  gfx::NativeWindow window_handle_;
+};

[tfarina, 2010/11/26 15:38:16]

DISALLOW_COPY_AND_ASSIGN?

[vrk (LEFT CHROMIUM), 2010/11/29 18:14:41]

Done.

+
+}  // namespace media
+
+#endif  // MEDIA_TOOLS_SHADER_BENCH_WINDOW_H_