media/tools/shader_bench/gl_painter.h - Issue 4873002: Benchmark tool for GPU-accelerated video rendering

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/tools/shader_bench/gl_painter.h

Issue 4873002: Benchmark tool for GPU-accelerated video rendering (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleaned up Window/Painter interface a little Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MEDIA_TOOLS_SHADER_BENCH_GL_PAINTER_H_

	6 #define MEDIA_TOOLS_SHADER_BENCH_GL_PAINTER_H_

	7

	8 #include "app/gfx/gl/gl_context.h"

	9 #include "base/scoped_ptr.h"

	10 #include "media/base/video_frame.h"

	11 #include "media/tools/shader_bench/painter.h"

	12

	13 class GLPainter : public Painter {
	Alpha Left Google 2010/11/15 20:43:51 Looking into Painter I found it's all related to G Looking into Painter I found it's all related to GL, is it possible that you merge two classes?
	14 public:

	15 GLPainter();

	16 virtual ~GLPainter();

	17 virtual void Initialize(int width, int height);

	18 virtual void Paint(scoped_refptr<media::VideoFrame> video_frame);

	19 virtual void SetGLContext(gfx::GLContext* context);
	Alpha Left Google 2010/11/15 20:43:51 Painter class also has a lot of GL stuff in it, ma Painter class also has a lot of GL stuff in it, maybe assign GLContext in Initialize() and remove this method?
	20 private:

	21 gfx::GLContext* context_;

	22 GLuint program_id_;

	23 GLuint textures_[3];

	24 };

	25

	26 #endif // MEDIA_TOOLS_SHADER_BENCH_GL_PAINTER_H_

OLD	NEW