create standard ssh keys for root in test-modified images

create standard ssh keys for root in test-modified images

[petkov, 2009-12-10 01:59:11]

LGTM if you fix the comment below.

http://codereview.chromium.org/487002/diff/2002/3002
File src/scripts/mod_for_test_scripts/350addTestAuthKeys (right):

http://codereview.chromium.org/487002/diff/2002/3002#newcode13
src/scripts/mod_for_test_scripts/350addTestAuthKeys:13: mkdir -p /root/.ssh
2>/dev/null
I don't think you need 2>/dev/null because mkdir -p
doesn't print anything if the folder already exists (or at
least add a space).

[micheas, 2009-12-10 02:39:37]

This just feels like a recipe for disaster to me.

A private ssh key in source control, specifically a private ssh key for root
that is world readable.

I would put that key in the known compromised keys black hole.

I am still looking at the tests, but is there a reason the keys can not be
generated on the fly? 

If there is a test that needs a specific key, can you only commit the public key
in source control?



On 2009/12/10 01:59:11, petkov wrote:
> LGTM if you fix the comment below.
> 
> http://codereview.chromium.org/487002/diff/2002/3002
> File src/scripts/mod_for_test_scripts/350addTestAuthKeys (right):
> 
> http://codereview.chromium.org/487002/diff/2002/3002#newcode13
> src/scripts/mod_for_test_scripts/350addTestAuthKeys:13: mkdir -p /root/.ssh
> 2>/dev/null
> I don't think you need 2>/dev/null because mkdir -p
> doesn't print anything if the folder already exists (or at
> least add a space).

[micheas, 2009-12-10 08:49:42]

Realizing the other issues I will withdraw my objection, and start working on
fixing these issues myself.

At least I have a starting point to work on the project.

On 2009/12/10 02:39:37, micheas wrote:
> This just feels like a recipe for disaster to me.
> 
> A private ssh key in source control, specifically a private ssh key for root
> that is world readable.
> 
> I would put that key in the known compromised keys black hole.
> 
> I am still looking at the tests, but is there a reason the keys can not be
> generated on the fly? 
> 
> If there is a test that needs a specific key, can you only commit the public
key
> in source control?
> 
> 
> 
> On 2009/12/10 01:59:11, petkov wrote:
> > LGTM if you fix the comment below.
> > 
> > http://codereview.chromium.org/487002/diff/2002/3002
> > File src/scripts/mod_for_test_scripts/350addTestAuthKeys (right):
> > 
> > http://codereview.chromium.org/487002/diff/2002/3002#newcode13
> > src/scripts/mod_for_test_scripts/350addTestAuthKeys:13: mkdir -p /root/.ssh
> > 2>/dev/null
> > I don't think you need 2>/dev/null because mkdir -p
> > doesn't print anything if the folder already exists (or at
> > least add a space).