Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 4870001: Enable sandboxed flash on windows by default.... (Closed)

Created:
10 years, 1 month ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Enable sandboxed flash on windows by default. It requires flash 10.1.103.19 or better, the current flash in trunk is 10.1.103.20 so we are fine. BUG=50796 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66022

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -18 lines) Patch
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/sandbox_policy.cc View 1 2 4 chunks +48 lines, -16 lines 0 comments Download
M chrome/plugin/plugin_main.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
10 years, 1 month ago (2010-11-12 02:27:21 UTC) #1
nsylvain
http://codereview.chromium.org/4870001/diff/1/chrome/common/sandbox_policy.cc File chrome/common/sandbox_policy.cc (right): http://codereview.chromium.org/4870001/diff/1/chrome/common/sandbox_policy.cc#newcode516 chrome/common/sandbox_policy.cc:516: !browser_command_line.HasSwitch(switches::kDisableFlashSandbox)); I think we still want to add kNoSandbox ...
10 years, 1 month ago (2010-11-12 19:41:58 UTC) #2
cpu_(ooo_6.6-7.5)
changes made, please look again. http://codereview.chromium.org/4870001/diff/1/chrome/common/sandbox_policy.cc File chrome/common/sandbox_policy.cc (right): http://codereview.chromium.org/4870001/diff/1/chrome/common/sandbox_policy.cc#newcode516 chrome/common/sandbox_policy.cc:516: !browser_command_line.HasSwitch(switches::kDisableFlashSandbox)); On 2010/11/12 19:41:58, ...
10 years, 1 month ago (2010-11-12 20:42:18 UTC) #3
nsylvain
10 years, 1 month ago (2010-11-12 23:45:31 UTC) #4
LGTN

Powered by Google App Engine
This is Rietveld 408576698