Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 4866002: Fix flakiness... (Closed)

Created:
10 years, 1 month ago by amit
Modified:
9 years ago
Reviewers:
ananta
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix flakiness Fix expectations and check for locked workstation to make tests depending on user input non-flaky. BUG=47596, 26549 TEST=FullTabUITest.CtrlN,FullTabUITest.KeyboardBackForward Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65994

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -36 lines) Patch
M chrome_frame/test/navigation_test.cc View 3 chunks +31 lines, -32 lines 1 comment Download
M chrome_frame/test/ui_test.cc View 3 chunks +8 lines, -4 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
amit
10 years, 1 month ago (2010-11-12 18:44:28 UTC) #1
ananta
10 years, 1 month ago (2010-11-12 21:10:33 UTC) #2
LGTM

http://codereview.chromium.org/4866002/diff/1/chrome_frame/test/navigation_te...
File chrome_frame/test/navigation_test.cc (right):

http://codereview.chromium.org/4866002/diff/1/chrome_frame/test/navigation_te...
chrome_frame/test/navigation_test.cc:306:
//.WillOnce(WatchWindow(&win_observer_mock, kAlertDlgCaption, ""));
Remove?

http://codereview.chromium.org/4866002/diff/1/chrome_frame/test/ui_test.cc
File chrome_frame/test/ui_test.cc (right):

http://codereview.chromium.org/4866002/diff/1/chrome_frame/test/ui_test.cc#ne...
chrome_frame/test/ui_test.cc:143: 
Add another .WillOnce here? Perhaps .WillOnce(testing::Return());

Powered by Google App Engine
This is Rietveld 408576698