Issue 4862002: Prevent a crash when visiting about:hang in two NTPs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4862002: Prevent a crash when visiting about:hang in two NTPs. (Closed)

Created:
10 years, 1 month ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Prevent a crash when visiting about:hang in two NTPs. Fixes how we assign about:hang to renderers and a related sanity check. BUG=59859 TEST=NewTabUITest.AboutHangInNTP Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66128

Patch Set 1 : Initial patch #

Total comments: 2

Patch Set 2 : Fix indent #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -8 lines)			Patch
M	chrome/browser/dom_ui/dom_ui_factory.h	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_factory.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui_uitest.cc	View		2 chunks	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_manager.cc	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM http://codereview.chromium.org/4862002/diff/2001/chrome/browser/dom_ui/dom_ui_factory.cc File chrome/browser/dom_ui/dom_ui_factory.cc (right): http://codereview.chromium.org/4862002/diff/2001/chrome/browser/dom_ui/dom_ui_factory.cc#newcode239 chrome/browser/dom_ui/dom_ui_factory.cc:239: // javacsript: URLs are allowed to run in ...

10 years, 1 month ago (2010-11-15 00:04:32 UTC) #2

Charlie Reis

10 years, 1 month ago (2010-11-15 17:49:27 UTC) #3

Thanks!

http://codereview.chromium.org/4862002/diff/2001/chrome/browser/dom_ui/dom_ui...
File chrome/browser/dom_ui/dom_ui_factory.cc (right):

http://codereview.chromium.org/4862002/diff/2001/chrome/browser/dom_ui/dom_ui...
chrome/browser/dom_ui/dom_ui_factory.cc:239: // javacsript: URLs are allowed to
run in DOM UI pages
On 2010/11/15 00:04:32, brettw wrote:
> All this stuff should be indented only 4 spaces (6 from the left edge).

Done.

Expand Messages | Collapse Messages