Issue 486012: Make sure the 'use_system_*' variables are actually visible in the relevant gyp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 486012: Make sure the 'use_system_*' variables are actually visible in the relevant gyp files. (Closed)

Created:
11 years ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make sure the 'use_system_*' variables are actually visible in the relevant gyp files. Retrying r34195, this time without libxslt, since we don't want to use the system version of that if we're not also using system libxml (merged from http://codereview.chromium.org/481011). BUG=29738

Patch Set 1 #

Patch Set 2 : add new dev dep #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -25 lines)			Patch
M	build/common.gypi	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	build/install-build-deps.sh	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	build/linux/system.gyp	View		1 chunk	+11 lines, -3 lines	0 comments	Download
M	third_party/bzip2/bzip2.gyp	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	third_party/libjpeg/libjpeg.gyp	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	third_party/libpng/libpng.gyp	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	third_party/zlib/zlib.gyp	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

LGTM I think you need bzip in install-build-deps.sh somewhere? That was the problem with the ...

11 years ago (2009-12-10 17:13:49 UTC) #2

Michael Moss

I also ran the slaves.py buildbot script to install that on the slaves.

11 years ago (2009-12-10 17:22:25 UTC) #4

LGTM

Expand Messages | Collapse Messages