Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 486011: DevTools: Add support for inspector layout tests. Step 1. (Closed)

Created:
11 years ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

DevTools: Add support for inspector layout tests. Step 1. Original CL by loislo: http://codereview.chromium.org/492004 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34251

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M webkit/glue/devtools/js/devtools.js View 1 chunk +17 lines, -0 lines 1 comment Download
M webkit/glue/devtools/js/inspector_controller_impl.js View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webdevtoolsagent_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/webdevtoolsagent_impl.cc View 2 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pfeldman
11 years ago (2009-12-10 15:44:52 UTC) #1
yurys
11 years ago (2009-12-10 15:53:06 UTC) #2
LGTM

http://codereview.chromium.org/486011/diff/1/5
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/486011/diff/1/5#newcode488
webkit/glue/devtools/js/devtools.js:488: // are processed.
no new line after the comment

Powered by Google App Engine
This is Rietveld 408576698