Issue 4858003: AppCacheUITests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4858003: AppCacheUITests (Closed)

Created:
10 years, 1 month ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, michaeln, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Split the layout tests run in the appcache ui tests into two groups, PHP dependent vs non-dependent. Also remove some tests that are racey from the layout tests run in these test cases. BUG=54717 TEST=yes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69085

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -32 lines)			Patch
	M	chrome/browser/appcache/appcache_ui_test.cc	View	1 2	3 chunks	+58 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

10 years ago (2010-12-10 18:37:05 UTC) #3

LGTM with a nit.

http://codereview.chromium.org/4858003/diff/3001/chrome/browser/appcache/appc...
File chrome/browser/appcache/appcache_ui_test.cc (right):

http://codereview.chromium.org/4858003/diff/3001/chrome/browser/appcache/appc...
chrome/browser/appcache/appcache_ui_test.cc:29: // The tests that don't depend
on PHP should be less flaky.
nit: If you keep the FLAKY prefix, please also keep the bug link. Otherwise,
remove the FLAKY prefix (up to you).

Expand Messages | Collapse Messages