Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 4854002: snap_start_tests: test NPN misprediction. (Closed)

Created:
10 years, 1 month ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

snap_start_tests: test NPN misprediction. When snap startting, we can hit a case where we predicted that we would negotiation an NPN protocol with a server, but then found that we were wrong. r65837 deal with this from the HTTP stack's point of view. This change adds tests to make sure that we can recover from the misprediction and get it right next time. BUG=none TEST=snap_start_tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -6 lines) Patch
M net/socket/ssl_client_socket_snapstart_unittest.cc View 3 chunks +45 lines, -0 lines 0 comments Download
M net/test/openssl_helper.cc View 5 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
agl
10 years, 1 month ago (2010-11-12 16:06:05 UTC) #1
Mike Belshe
10 years, 1 month ago (2010-11-16 18:54:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698