Issue 4847001: Use 'ChromeFrame' product id instead of chrome for GCF launches...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4847001: Use 'ChromeFrame' product id instead of chrome for GCF launches... (Closed)

Created:
10 years, 1 month ago by amit

Modified:
9 years ago

Reviewers:
robertshield, Munjal (Google)

CC:
chromium-reviews, cpu_(ooo_6.6-7.5)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use 'ChromeFrame' product id instead of chrome for GCF launches When chrome.exe is launched with --chrome-frame switch, we need to gather any crashes in this mode under 'ChromeFrame' product id under go/crash. Since ChromeFrame exists only on windows, this change is limited to breakpad_win.cc for now. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66336

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/app/breakpad_win.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages