Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 4840001: Cleanup: Remove chrome/browser/browser_navigator.* and references. (Closed)

Created:
10 years, 1 month ago by James Hawkins
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Cleanup: Remove chrome/browser/browser_navigator.* and references. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65881

Patch Set 1 #

Patch Set 2 : Mac fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -415 lines) Patch
M chrome/browser/browser_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_init.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/browser_navigator.h View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/browser_navigator.cc View 1 chunk +0 lines, -384 lines 0 comments Download
M chrome/browser/cocoa/applescript/window_applescript.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/filebrowse_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/find_bar_host_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/browser_with_test_window_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/in_process_browser_test.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
James Hawkins
10 years, 1 month ago (2010-11-11 22:37:12 UTC) #1
Ben Goodger (Google)
I feel like I reviewed this change from someone else earlier... perhaps thestig. -Ben On ...
10 years, 1 month ago (2010-11-11 23:44:40 UTC) #2
James Hawkins
On 2010/11/11 23:44:40, Ben Goodger wrote: > I feel like I reviewed this change from ...
10 years, 1 month ago (2010-11-12 00:25:25 UTC) #3
Ben Goodger (Google)
Nope. I must be imagining things. LGTM.
10 years, 1 month ago (2010-11-12 00:32:49 UTC) #4
sadrul
10 years, 1 month ago (2010-11-13 05:55:03 UTC) #5
On 2010/11/11 23:44:40, Ben Goodger wrote:
> I feel like I reviewed this change from someone else earlier... perhaps
> thestig.

It was http://codereview.chromium.org/4647007. I have updated that CL after
merging with these changes.

Powered by Google App Engine
This is Rietveld 408576698