Add PluginDataRemover.

chrome/browser/plugin_service.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "chrome/browser/plugin_service.h"
 
 #include "base/command_line.h"
 #include "base/path_service.h"
@@ skipping 208 matching lines @@
       return plugin;
   }
 
   return NULL;
 }
 
 PluginProcessHost* PluginService::FindOrStartPluginProcess(
     const FilePath& plugin_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
-  PluginProcessHost *plugin_host = FindPluginProcess(plugin_path);
+  if (plugin_path.value().empty())

[jam, 2010/11/12 20:44:58]

curious, any reason to change this logic?  it seems redundant to have this check
since GetPluginInfoByPath will return null.  if the dcheck/notreached can fire
in normal circumstances, then perhaps no need to have it.  if it does fire, when
does that happen?

+    return NULL;
+
+  PluginProcessHost* plugin_host = FindPluginProcess(plugin_path);
   if (plugin_host)
     return plugin_host;
 
   WebPluginInfo info;
   if (!NPAPI::PluginList::Singleton()->GetPluginInfoByPath(
-          plugin_path, &info)) {
-    DCHECK(false);
+      plugin_path, &info)) {
+    NOTREACHED();
     return NULL;
   }
 
   // This plugin isn't loaded by any plugin process, so create a new process.
-  plugin_host = new PluginProcessHost();
-  if (!plugin_host->Init(info, ui_locale_)) {
-    DCHECK(false);  // Init is not expected to fail
-    delete plugin_host;
+  scoped_ptr<PluginProcessHost> new_host(new PluginProcessHost());
+  if (!new_host->Init(info, ui_locale_)) {
+    NOTREACHED();  // Init is not expected to fail
     return NULL;
   }
 
-  return plugin_host;
+  return new_host.release();
 }
 
 void PluginService::OpenChannelToPlugin(
     const GURL& url,
     const std::string& mime_type,
     PluginProcessHost::Client* client) {
   // The PluginList::GetFirstAllowedPluginInfo may need to load the
   // plugins.  Don't do it on the IO thread.
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
@@ skipping 179 matching lines @@
     info.mime_types = ASCIIToWide(JoinString(plugins[i].mime_types, '|'));
 
     // These NPAPI entry points will never be called.  TODO(darin): Come up
     // with a cleaner way to register pepper plugins with the NPAPI PluginList,
     // or perhaps refactor the PluginList to be less specific to NPAPI.
     memset(&info.entry_points, 0, sizeof(info.entry_points));
 
     NPAPI::PluginList::Singleton()->RegisterInternalPlugin(info);
   }
 }