Issue 4827001: Add a preference to enable safebrowsing malware reports....

Issue 4827001: Add a preference to enable safebrowsing malware reports.... (Closed)

Created:
10 years, 1 month ago by panayiotis

Modified:
9 years, 7 months ago

Reviewers:
lzheng

CC:
chromium-reviews, ben+cc_chromium.org, ian fette, kewang

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a preference to enable safebrowsing malware reports. BUG=60831 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66651

Patch Set 3 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
M	chrome/browser/options_util.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/profile.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

panayiotis

Ke will follow up with code to actually change this preference from the interstitial. I ...

10 years, 1 month ago (2010-11-11 22:08:40 UTC) #1

lzheng

http://codereview.chromium.org/4827001/diff/7001/chrome/browser/options_util.cc File chrome/browser/options_util.cc (right): http://codereview.chromium.org/4827001/diff/7001/chrome/browser/options_util.cc#newcode65 chrome/browser/options_util.cc:65: prefs::kSafeBrowsingMalwareReportsEnabled, Could this just be kSafeBrowsingReportingEnabled? http://codereview.chromium.org/4827001/diff/7001/chrome/common/pref_names.cc File chrome/common/pref_names.cc ...

10 years, 1 month ago (2010-11-13 00:01:35 UTC) #2

panayiotis

Sure, done http://codereview.chromium.org/4827001/diff/7001/chrome/browser/options_util.cc File chrome/browser/options_util.cc (right): http://codereview.chromium.org/4827001/diff/7001/chrome/browser/options_util.cc#newcode65 chrome/browser/options_util.cc:65: prefs::kSafeBrowsingMalwareReportsEnabled, On 2010/11/13 00:01:35, lzheng wrote: > ...

10 years, 1 month ago (2010-11-13 01:13:45 UTC) #3

lzheng

10 years, 1 month ago (2010-11-13 06:36:16 UTC) #4

LGTM.
FYI: I am still looking at the other CL.

On 2010/11/13 01:13:45, panayiotis wrote:
> Sure, done
> 
>
http://codereview.chromium.org/4827001/diff/7001/chrome/browser/options_util.cc
> File chrome/browser/options_util.cc (right):
> 
>
http://codereview.chromium.org/4827001/diff/7001/chrome/browser/options_util....
> chrome/browser/options_util.cc:65: prefs::kSafeBrowsingMalwareReportsEnabled,
> On 2010/11/13 00:01:35, lzheng wrote:
> > Could this just be kSafeBrowsingReportingEnabled?
> 
> Done.
> 
> http://codereview.chromium.org/4827001/diff/7001/chrome/common/pref_names.cc
> File chrome/common/pref_names.cc (right):
> 
>
http://codereview.chromium.org/4827001/diff/7001/chrome/common/pref_names.cc#...
> chrome/common/pref_names.cc:122: // Boolean that is true when SafeBrowsing
> Malware Reports are enabled.
> On 2010/11/13 00:01:35, lzheng wrote:
> > Should this be "SafeBrowsing Malware Report is enabled"?
> 
> Done.

Expand Messages | Collapse Messages