crosutils: move image_common.sh to lib/cros_image_common.sh

crosutils: move image_common.sh to lib/cros_image_common.sh

The team is moving utility/library scripts into 'lib' folder.
image_common.sh should follow this policy.

Also refined the parameter check of mk_memento_images.sh

BUG=chromium-os:5208
TEST=./make_factory_package.sh --factory PATH_TO_FACTORY --release PATH_TO_RELEASE;
     # factory bundle created successfully
     ./mk_memento_images.sh PATH_TO_PART2 PATH_TO_PART3
     # update.gz created successfully
     ./mk_memento_images.sh PATH_TO_IMGE 2 3
     # update.gz created successfully

Change-Id: I3afecf05da2832986723f28b595045d0540ea9e9

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bcc60b6

[sosa, 2010-11-12 19:42:02]

LGTM w/ nit

http://codereview.chromium.org/4825004/diff/1/make_factory_package.sh
File make_factory_package.sh (right):

http://codereview.chromium.org/4825004/diff/1/make_factory_package.sh#newcode23
make_factory_package.sh:23: [ -f "$LIB_CROS_IMAGE_COMMON" ] ||
Why do you do these extra checks here for include scripts?  It seems a little
against common style in other scripts.

Can't you just simplify this to ... 

. "$(dirname "$0")/image_common.sh" || die "Missing image_common.sh"

[Hung-Te, 2010-11-12 19:56:25]

http://codereview.chromium.org/4825004/diff/1/make_factory_package.sh
File make_factory_package.sh (right):

http://codereview.chromium.org/4825004/diff/1/make_factory_package.sh#newcode23
make_factory_package.sh:23: [ -f "$LIB_CROS_IMAGE_COMMON" ] ||
There's some plan to create a mini factory bundle having these scripts together
(i.e., not the complete checkout of scripts folder), and I'm not sure if we will
still have 'lib' folder at that time; so an additional check to find the library
script in more place.

Anyway since that's not done yet, we can postpone checking additional path until
the day we really need it. Do you think that would be better?

[Hung-Te, 2010-11-12 20:07:07]

Removed the extra path trial. (die is not available in mk_memento_images.sh
because it does not depend on common.h)

Please take a look again, thanks.

[sosa, 2010-11-12 20:19:12]

LGTM