Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 4824003: crosutils: refine memento image / factory package creation (Closed)

Created:
10 years, 1 month ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Nick Sanders, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, adlr, Randall Spangler, Tammo Spalink
Visibility:
Public.

Description

crosutils: refine memento image / factory package creation This CL improves creation of memento / factory image payload by: - verbose progress report - allowing to compress by pigz, the parallel version of gzip - prevents unpacking entire image if partition tools (cgpt/parted) is available. BUG=chromium-os:6536, chromium-os:5208 TEST=Verified executing "time ./make_factory_package.sh ..." for ToT factory bundle: - before this CL (memento gzip param is not -9): 3m53.126s - after this CL, without pigz, with cgpt: 2m34.897s - after this CL, with pigz+cgpt, memento_gz=-9: 0m45.603s - after this CL, with pigz, without cgpt/parted, memento_gz=-9: 1m49.748s Also verified such bundle can be installed on a real netbook device. Change-Id: Ie182844ea5482d6d321b9549fa584377edf7dfe3 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=51484a9

Patch Set 1 #

Total comments: 1

Patch Set 2 : add blocksize and more TODO comments/alerts #

Patch Set 3 : should not compress twice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -49 lines) Patch
A image_common.sh View 1 1 chunk +106 lines, -0 lines 0 comments Download
M make_factory_package.sh View 1 2 5 chunks +65 lines, -14 lines 0 comments Download
M mk_memento_images.sh View 1 3 chunks +69 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hung-Te
10 years, 1 month ago (2010-11-12 15:27:57 UTC) #1
Hung-Te
for max speed, please install pigz in your platform first, by "sudo apt-get install pigz" ...
10 years, 1 month ago (2010-11-12 15:31:22 UTC) #2
Nick Sanders
lgtm, looks great!
10 years, 1 month ago (2010-11-12 17:55:46 UTC) #3
Nick Sanders
http://codereview.chromium.org/4824003/diff/1/make_factory_package.sh File make_factory_package.sh (right): http://codereview.chromium.org/4824003/diff/1/make_factory_package.sh#newcode159 make_factory_package.sh:159: if ! has_part_tools; then FYI You can avoid running ...
10 years, 1 month ago (2010-11-12 18:05:41 UTC) #4
sosa
10 years, 1 month ago (2010-11-12 19:08:20 UTC) #5
Can you move image_common.sh to lib?  We're slowly trying to move executables
into bin and lib's into lib (src/scripts/lib)

Powered by Google App Engine
This is Rietveld 408576698