Send malware reports when a user opts-in from the safe browsing interstitial ...

chrome/browser/safe_browsing/protocol_manager.cc

Index: chrome/browser/safe_browsing/protocol_manager.cc
===================================================================
--- chrome/browser/safe_browsing/protocol_manager.cc	(revision 65873)
+++ chrome/browser/safe_browsing/protocol_manager.cc	(working copy)
@@ -604,6 +604,21 @@
   safebrowsing_reports_.insert(report);
 }
 
+// Sends a malware report.
+void SafeBrowsingProtocolManager::SendMalwareReport(
+    const std::string* request_data) {

[lzheng, 2010/11/16 00:18:12]

why it is not const std::string& for request_data?

[panayiotis, 2010/11/18 22:04:37]

Done.

+  GURL report_url = MalwareClientReportUrl();
+  URLFetcher* fetcher = new URLFetcher(report_url, URLFetcher::POST, this);
+  fetcher->set_load_flags(net::LOAD_DISABLE_CACHE);
+  fetcher->set_request_context(request_context_getter_);
+  fetcher->set_upload_data("application/octet-stream", *request_data);
+  // Don't try too hard to send if there's failures.
+  fetcher->set_automatically_retry_on_5xx(false);
+  fetcher->Start();
+  safebrowsing_reports_.insert(fetcher);
+}
+
+
 // static
 std::string SafeBrowsingProtocolManager::FormatList(
     const SBListChunkRanges& list, bool use_mac) {
@@ -704,6 +719,15 @@
       is_subresource));
 }
 
+GURL SafeBrowsingProtocolManager::MalwareClientReportUrl() const {
+  std::string url = StringPrintf(
+          "%s/clientreport/malware?client=%s&appver=%s&pver=1.0",
+          mackey_url_prefix_.c_str(),

[lzheng, 2010/11/16 00:18:12]

Why do we use the mackey_url_prefix_ for malwareclientreport? Why can't we use
SafeBrowsingReportUrl? It is a little bit confusing to have two report urls in
this class. I wonder if the two urls could just be one but with different level
of reporting details.

[panayiotis, 2010/11/18 22:04:37]

these reports will go to https://sb-ssl.google.com/ instead of
http://safebrowsing.clients.google.com/ (no ssl)

It is confusing indeed. One solution is to change the server-side so that we can
handle both "pings" and advanced reports from the same services, but that may
not be trivial. 

Another idea is to rename the old "uma reports" as "pings" here so we can easily
distinguish the two. That would be faster since we don't have to change the
server-side. 


On 2010/11/16 00:18:12, lzheng wrote:

+          client_name_.c_str(),
+          version_.c_str());
+  return GURL(url);
+}
+
 GURL SafeBrowsingProtocolManager::NextChunkUrl(const std::string& url) const {
   std::string next_url;
   if (!StartsWithASCII(url, "http://", false) &&