Send malware reports when a user opts-in from the safe browsing interstitial ...

chrome/browser/safe_browsing/malware_report.cc

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Implementation of the SafeBrowsingMalwareReport class.
+
+#include "chrome/browser/safe_browsing/malware_report.h"
+
+#include "chrome/browser/browser_thread.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"
+#include "chrome/browser/tab_contents/navigation_entry.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
+#include "chrome/browser/safe_browsing/csd.pb.h"
+
+// Create a SafeBrowsingMalwareReport for the given tab.
+// Runs in the UI thread.
+SafeBrowsingMalwareReport::SafeBrowsingMalwareReport(
+    TabContents* tab_contents,
+    const SafeBrowsingService::UnsafeResource resource)
+    : tab_contents_(tab_contents),
+      resource_(resource) {
+  StartCollection();
+}
+
+SafeBrowsingMalwareReport::~SafeBrowsingMalwareReport() {}
+

[lzheng, 2010/11/16 00:18:12]

I think we should not show the "report" checkbox when the content is not valid
for reporting (internal sites, https, etc.). Can you confirm that?

[panayiotis, 2010/11/18 22:04:37]

Agreed. I added a comment on the relevant CL so we don't forget.
(http://codereview.chromium.org/5102001/) 

That said, if the page url is http we still want to filter out any https
sub-resources from the report, so this is still needed.

+bool SafeBrowsingMalwareReport::IsPublicUrl(const GURL& url) const {
+  return url.SchemeIs("http");  // TODO(panayiotis): also skip internal urls.
+}
+
+void SafeBrowsingMalwareReport::AddNode(
+    const std::string& url,
+    const std::string& parent) {
+  safe_browsing::ClientMalwareReportRequest::Resource* resource =

[lzheng, 2010/11/16 00:18:12]

Where is the resource released? 

[panayiotis, 2010/11/18 22:04:37]

Oops, I got the linked_ptr semantics completely wrong. Fixed, thanks.

+      new safe_browsing::ClientMalwareReportRequest::Resource();
+  if (!IsPublicUrl(GURL(url)))

[lzheng, 2010/11/16 00:18:12]

Will the resource be leaked here?

[panayiotis, 2010/11/18 22:04:37]

Oops, yes. moved the exit condition above. 

+    return;
+  resource->set_url(url);
+  if (!parent.empty() && IsPublicUrl(GURL(parent)))
+    resource->set_parent(parent);
+  urls_[url].reset(resource);
+}
+
+void SafeBrowsingMalwareReport::StartCollection() {
+  DLOG(INFO) << "Starting to compute a new malware report.";
+  report_.reset(new safe_browsing::ClientMalwareReportRequest());
+
+  if (IsPublicUrl(resource_.url)) {
+    report_->set_malware_url(resource_.url.spec());
+  }
+
+  GURL page_url = tab_contents_->GetURL();
+  if (IsPublicUrl(page_url)) {
+    report_->set_page_url(page_url.spec());
+  }
+
+  GURL referrer_url;
+  NavigationEntry* nav_entry = tab_contents_->controller().GetActiveEntry();
+  if (nav_entry) {
+    referrer_url = nav_entry->referrer();
+    if (IsPublicUrl(referrer_url)) {
+      report_->set_referrer_url(referrer_url.spec());
+    }
+  }
+
+  // Add the nodes, starting from the page url.
+  AddNode(page_url.spec(), "");
+
+  // Add the resource_url and its original url, if non-empty and different.
+  if (!resource_.original_url.spec().empty() &&
+      resource_.url != resource_.original_url) {
+    // Add original_url, as the parent of resource_url.
+    AddNode(resource_.original_url.spec(), "");
+    AddNode(resource_.url.spec(), resource_.original_url.spec());
+  } else {
+    AddNode(resource_.url.spec(), "");
+  }
+
+  // Add the referrer url.
+  if (nav_entry && !referrer_url.spec().empty()) {
+    AddNode(referrer_url.spec(), "");
+  }
+
+  // Add all the urls in our |urls_| map to the |report_| protobuf.
+  for (ResourceMap::const_iterator it = urls_.begin();
+       it != urls_.end(); it++) {
+    safe_browsing::ClientMalwareReportRequest::Resource* pb_resource =
+        report_->add_nodes();
+    pb_resource->CopyFrom(*(it->second));
+  }
+}
+
+// Called from the SB Service on the IO thread.
+const std::string* SafeBrowsingMalwareReport::GetSerializedReport() {
+  scoped_ptr<std::string> request_data(new std::string());
+  if (!report_->SerializeToString(request_data.get())) {
+    DLOG(ERROR) << "Unable to serialize the malware report.";
+  }
+
+  return request_data.release();
+}