chrome/browser/resources/options/personal_options.html - Issue 4821003: DOMUI: Turn the google dashboard link into a real link and fix the behavior of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/personal_options.html

Issue 4821003: DOMUI: Turn the google dashboard link into a real link and fix the behavior of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/dom_ui/options/personal_options_handler.cc ('K') | « chrome/browser/dom_ui/options/personal_options_handler.cc ('k') | chrome/browser/resources/options/personal_options.js » ('j') | chrome/browser/resources/options/personal_options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/personal_options.html

diff --git a/chrome/browser/resources/options/personal_options.html b/chrome/browser/resources/options/personal_options.html

index 5988915d5fb77dd8ece624d64bca70d47e76b7b7..61fefe2284babe40b7dcf3c3638ed2f99b9de2a9 100644

--- a/chrome/browser/resources/options/personal_options.html

+++ b/chrome/browser/resources/options/personal_options.html

@@ -26,8 +26,8 @@

</div>

- <button id="privacy-dashboard-link" class="link-button"

- i18n-content="privacy_dashboard_link"></button>

+ <a href="https://www.google.com/dashboard" id="privacy-dashboard-link"

+ i18n-content="privacy_dashboard_link" target="_blank"></a>

</div>

</section>

@@ -96,7 +96,7 @@

<div>

- <a i18n-content="themes_gallery" id="themes-gallery" href="#"></a>

+ <a id="themes-gallery" i18n-content="themes_gallery"></a>

</div>

</section>

</if>