DOMUI: Turn the google dashboard link into a real link and fix the behavior of

chrome/browser/resources/options/personal_options.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
 
   // State variables.
   var syncEnabled = false;
@@ skipping 22 matching lines @@
       var self = this;
       $('customize-sync').onclick = function(event) {
         OptionsPage.showPageByName('sync');
       };
       $('start-stop-sync').onclick = function(event) {
         if (self.syncSetupCompleted)
           self.showStopSyncingOverlay_();
         else
           self.showSyncLoginDialog_();
       };
-      $('privacy-dashboard-link').onclick = function(event) {
-        chrome.send('openPrivacyDashboardTabAndActivate');
-      };
-
       $('showpasswords').onclick = function(event) {
         PasswordsExceptions.load();
         OptionsPage.showPageByName('passwordsExceptions');
         OptionsPage.showTab($('passwords-nav-tab'));
         chrome.send('coreOptionsUserMetricsAction',
             ['Options_ShowPasswordsExceptions']);
       };
-
       $('autofill_options').onclick = function(event) {
         OptionsPage.showPageByName('autoFillOptions');
         chrome.send('coreOptionsUserMetricsAction',
             ['Options_ShowAutoFillSettings']);
       };
 
       if (!cr.isChromeOS) {
         $('import_data').onclick = function(event) {
           OptionsPage.showOverlay('importDataOverlay');
           chrome.send('coreOptionsUserMetricsAction', ['Import_ShowDlg']);
         };
       }
 
       if (!cr.isChromeOS && navigator.platform.match(/linux|BSD/i)) {
         $('themes_GTK_button').onclick = function(event) {
           chrome.send('themesSetGTK');
         };
-
         $('themes_set_classic').onclick = function(event) {
           chrome.send('themesReset');
         };
-        $('themes-gallery').onclick = function(event) {
-          chrome.send('themesGallery');
-        }
       }
 
       if (cr.isMac || cr.isWindows || cr.isChromeOS) {
         $('themes_reset').onclick = function(event) {
           chrome.send('themesReset');
         };
-        $('themes-gallery').onclick = function(event) {
-          chrome.send('themesGallery');
-        }
       }
 
       if (cr.isChromeOS) {
         chrome.send('loadAccountPicture');
       }
+
+      self.requestThemesGalleryURL_();
     },
 
     showStopSyncingOverlay_: function(event) {
       AlertOverlay.show(
           localStrings.getString('stop_syncing_title'),
           localStrings.getString('stop_syncing_explanation'),
           localStrings.getString('stop_syncing_confirm_button_label'),
           undefined,
           function() { chrome.send('stopSyncing'); });
     },
 
     showSyncLoginDialog_: function(event) {
       chrome.send('showSyncLoginDialog');
     },
 
+    requestThemesGalleryURL_: function() {
+      chrome.send('getThemesGalleryURL');
+    },
+
     setElementVisible_: function(element, visible) {
       element.style.display = visible ? 'inline' : 'none';
     },
 
     setElementClassSyncError_: function(element, visible) {
       visible ? element.classList.add('sync-error') :
                 element.classList.remove('sync-error');
     },
 
     setSyncEnabled_: function(enabled) {
@@ skipping 60 matching lines @@
       if (!cr.isChromeOS && navigator.platform.match(/linux|BSD/i)) {
         $('themes_GTK_button').disabled = !enabled;
       }
     },
 
     setClassicThemeButtonEnabled_: function(enabled) {
       if (!cr.isChromeOS && navigator.platform.match(/linux|BSD/i)) {
         $('themes_set_classic').disabled = !enabled;
       }
     },
+
+    setThemesGalleryURL_: function(url) {
+      $('themes-gallery').href = url;
+      $('themes-gallery').target = '_blank';  // Open in a new tab.

[arv (Not doing code reviews), 2010/11/12 01:17:25]

Can you link to a webkit bug here?

[James Hawkins, 2010/11/12 23:47:20]

I've actually removed this piece of code. Do you want me to file a WK bug?

+    },
   };
 
   // Forward public APIs to private implementations.
   [
     'setSyncEnabled',
     'setSyncSetupCompleted',
     'setAccountPicture',
     'setSyncStatus',
     'setSyncStatusErrorVisible',
     'setSyncActionLinkErrorVisible',
     'setSyncActionLinkEnabled',
     'setSyncActionLinkLabel',
     'setStartStopButtonVisible',
     'setStartStopButtonEnabled',
     'setStartStopButtonLabel',
     'setCustomizeButtonVisible',
     'setCustomizeButtonEnabled',
     'setCustomizeButtonLabel',
     'setGtkThemeButtonEnabled',
     'setClassicThemeButtonEnabled',
+    'setThemesGalleryURL',
   ].forEach(function(name) {
     PersonalOptions[name] = function(value) {
       PersonalOptions.getInstance()[name + '_'](value);
     };
   });
 
   // Export
   return {
     PersonalOptions: PersonalOptions
   };
 
 });