Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: chrome/browser/chromeos/status/network_menu.cc

Issue 4818002: Fix favorite and auto_connect property usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix for comments. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/status/network_menu.h ('k') | chrome/browser/resources/network_menu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/status/network_menu.cc
diff --git a/chrome/browser/chromeos/status/network_menu.cc b/chrome/browser/chromeos/status/network_menu.cc
index 7cf5532cd0d3a3a441a97b5761e823e18dbc0bb6..f0eceee3542dd9ce5a5cb1ba4bc340247e181159 100644
--- a/chrome/browser/chromeos/status/network_menu.cc
+++ b/chrome/browser/chromeos/status/network_menu.cc
@@ -145,6 +145,7 @@ bool NetworkMenu::GetNetworkAt(int index, NetworkInfo* info) const {
}
info->ip_address = wifi->ip_address();
info->remembered = wifi->favorite();
+ info->auto_connect = info->remembered ? wifi->auto_connect() : true;
} else {
res = false; // Network not found, hide entry.
}
@@ -200,7 +201,7 @@ bool NetworkMenu::GetNetworkAt(int index, NetworkInfo* info) const {
bool NetworkMenu::ConnectToNetworkAt(int index,
const std::string& passphrase,
const std::string& ssid,
- int remember) const {
+ int auto_connect) const {
int flags = menu_items_[index].flags;
NetworkLibrary* cros = CrosLibrary::Get()->GetNetworkLibrary();
if (flags & FLAG_WIFI) {
@@ -208,8 +209,8 @@ bool NetworkMenu::ConnectToNetworkAt(int index,
menu_items_[index].wireless_path);
if (wifi) {
// Connect or reconnect.
- if (remember >= 0)
- wifi->set_favorite(remember ? true : false);
+ if (auto_connect >= 0)
+ wifi->set_auto_connect(auto_connect ? true : false);
if (cros->wifi_network() &&
wifi->service_path() == cros->wifi_network()->service_path()) {
// Show the config settings for the active network.
@@ -279,10 +280,11 @@ bool NetworkMenu::ConnectToNetworkAt(int index,
} else if (flags & FLAG_OTHER_NETWORK) {
bool connected = false;
if (MenuUI::IsEnabled()) {
- bool favorite = remember == 0 ? false : true; // default is true
+ // default is true
+ bool auto_connect_bool = auto_connect == 0 ? false : true;
connected = cros->ConnectToWifiNetwork(
passphrase.empty() ? SECURITY_NONE : SECURITY_UNKNOWN,
- ssid, passphrase, std::string(), std::string(), favorite);
+ ssid, passphrase, std::string(), std::string(), auto_connect_bool);
}
if (!connected) {
ShowOther();
« no previous file with comments | « chrome/browser/chromeos/status/network_menu.h ('k') | chrome/browser/resources/network_menu.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698