Fix favorite and auto_connect property usage.

chrome/browser/chromeos/status/network_menu.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/status/network_menu.h"
 
 #include <algorithm>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
@@ skipping 182 matching lines @@
     info->remembered = true;
   } else {
     // Not a network, e.g options, separator.
   }
   return res;
 }
 
 bool NetworkMenu::ConnectToNetworkAt(int index,
                                      const std::string& passphrase,
                                      const std::string& ssid,
                                      int remember) const {

[Charlie Lee, 2010/11/12 12:29:57]

why is this an int? and is this misnamed? should it be auto-connect instead?
When we connect to a new network, we give user an option to auto-connect or not,
right?

who calls this method?

[kochi, 2010/11/15 08:46:13]

I think 'int' is because it is adapted to the callback from
DOMUI JavaScript network menu code, which is disabled for now.

I did more complete renaming of s/remember/autocomplete/ now.

   int flags = menu_items_[index].flags;
   NetworkLibrary* cros = CrosLibrary::Get()->GetNetworkLibrary();
   if (flags & FLAG_WIFI) {
     WifiNetwork* wifi = cros->FindWifiNetworkByPath(
         menu_items_[index].wireless_path);
     if (wifi) {
       // Connect or reconnect.
       if (remember >= 0)

[Charlie Lee, 2010/11/12 12:29:57]

if remember means auto-connect, then this is the right thing to do.

[kochi, 2010/11/15 08:46:13]

Renamed to auto_connect.

On 2010/11/12 12:29:57, Charlie Lee wrote:

-        wifi->set_favorite(remember ? true : false);
+        wifi->set_auto_connect(remember ? true : false);
       if (cros->wifi_network() &&
           wifi->service_path() == cros->wifi_network()->service_path()) {
         // Show the config settings for the active network.
         ShowWifi(wifi, false);
         return true;
       }
       bool connected = false;
       if (wifi->encrypted()) {
         if (wifi->IsCertificateLoaded()) {
           connected = cros->ConnectToWifiNetwork(
@@ skipping 48 matching lines @@
         }
       }
     } else {
       // If we are attempting to connect to a network that no longer exists,
       // display a notification.
       // TODO(stevenjb): Show notification.
     }
   } else if (flags & FLAG_OTHER_NETWORK) {
     bool connected = false;
     if (MenuUI::IsEnabled()) {
       bool favorite = remember == 0 ? false : true;  // default is true

[Charlie Lee, 2010/11/12 12:29:57]

rename this to auto-connect?

[kochi, 2010/11/15 08:46:13]

Done.

       connected = cros->ConnectToWifiNetwork(
           passphrase.empty() ? SECURITY_NONE : SECURITY_UNKNOWN,
           ssid, passphrase, std::string(), std::string(), favorite);
     }
     if (!connected) {
       ShowOther();
     }
   }
   return true;
 }
@@ skipping 475 matching lines @@
                                       chromeos::TYPE_WIFI);
       browser->ShowOptionsTab(page);
     }
   } else {
     const bool kFocusLogin = true;
     ShowNetworkConfigView(new NetworkConfigView(), kFocusLogin);
   }
 }
 
 }  // namespace chromeos