Fix favorite and auto_connect property usage.

chrome/browser/chromeos/cros/network_library.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_CROS_NETWORK_LIBRARY_H_
 #define CHROME_BROWSER_CHROMEOS_CROS_NETWORK_LIBRARY_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 113 matching lines @@
     }
     const std::string& path;
   };
 
   const std::string& name() const { return name_; }
   int strength() const { return strength_; }
   bool auto_connect() const { return auto_connect_; }
   bool favorite() const { return favorite_; }
 
   void set_auto_connect(bool auto_connect) { auto_connect_ = auto_connect; }
-  void set_favorite(bool favorite) { favorite_ = favorite; }
+  // No setter for favorite_.

[Charlie Lee, 2010/11/12 12:29:57]

Please explain why. We don't have a setter for favorite because to unfavorite a
network is equivalent to forget a network, so we call forget network on cros for
that.

[kochi, 2010/11/15 08:46:13]

adopted your comment.
thanks!

On 2010/11/12 12:29:57, Charlie Lee wrote:

 
   // Network overrides.
   virtual void Clear();
 
  protected:
   WirelessNetwork()
       : Network(),
         strength_(0),
         auto_connect_(false),
         favorite_(false) {}
@@ skipping 422 matching lines @@
   virtual std::string GetHtmlInfo(int refresh) = 0;
 
   // Factory function, creates a new instance and returns ownership.
   // For normal usage, access the singleton via CrosLibrary::Get().
   static NetworkLibrary* GetImpl(bool stub);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_CROS_NETWORK_LIBRARY_H_