Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: net/disk_cache/file_win.cc

Issue 48155: Disk cache: A few minor fixes to make coverity happy. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/entry_impl.cc ('k') | net/disk_cache/mem_entry_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/file_win.cc
===================================================================
--- net/disk_cache/file_win.cc (revision 12016)
+++ net/disk_cache/file_win.cc (working copy)
@@ -62,7 +62,9 @@
MyOverlapped::~MyOverlapped() {
if (delete_buffer_) {
DCHECK(!callback_);
- delete buffer_;
+ // This whole thing could be updated to use IOBuffer, but PostWrite is not
+ // used at the moment. TODO(rvargas): remove or update this code.
+ delete[] reinterpret_cast<const char*>(buffer_);
}
}
« no previous file with comments | « net/disk_cache/entry_impl.cc ('k') | net/disk_cache/mem_entry_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698