Issue 48127: Introducing a new StrNDup function that uses new[] for when we dispose the re...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48127: Introducing a new StrNDup function that uses new[] for when we dispose the re... (Closed)

Created:
11 years, 9 months ago by olehougaard

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Introducing a new StrNDup function that uses new[] for when we dispose the result using delete[]. Committed: http://code.google.com/p/v8/source/detail?r=1532

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -4 lines)			Patch
M	src/allocation.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/allocation.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/d8-readline.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 9 months ago (2009-03-18 12:26:15 UTC) #2

LGTM

How about getting rid of OS::StrDup and OS::StrNDup alltogether? I think this
change removed the only use of OS::StrNDup and OS::StrDup is only used in a few
tests.

Expand Messages | Collapse Messages