Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: src/d8-debug.cc

Issue 48126: Fixing potentially problematic usage of OS::StrDup that caused some strings t... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/flags.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 while (true) { 325 while (true) {
326 // read keyboard input. 326 // read keyboard input.
327 char command[kBufferSize]; 327 char command[kBufferSize];
328 char* str = fgets(command, kBufferSize, stdin); 328 char* str = fgets(command, kBufferSize, stdin);
329 if (str == NULL) { 329 if (str == NULL) {
330 break; 330 break;
331 } 331 }
332 332
333 // Pass the keyboard command to the main thread. 333 // Pass the keyboard command to the main thread.
334 remote_debugger_->KeyboardCommand( 334 remote_debugger_->KeyboardCommand(
335 i::SmartPointer<char>(i::OS::StrDup(command))); 335 i::SmartPointer<char>(i::StrDup(command)));
336 } 336 }
337 } 337 }
338 338
339 339
340 } // namespace v8 340 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698