Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/extensions/extension_error_reporter.h

Issue 48105: Remove unneeded uses of base/ref_counted.h. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/bookmarks/bookmark_service.h ('k') | chrome/browser/gears_integration.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_ERROR_REPORTER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_ERROR_REPORTER_H_
6 #define CHROME_BROWSER_EXTENSIONS_ERROR_REPORTER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_ERROR_REPORTER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/message_loop.h" 11 #include "base/message_loop.h"
12 #include "base/ref_counted.h"
13 12
14 // Exposes an easy way for the various components of the extension system to 13 // Exposes an easy way for the various components of the extension system to
15 // report errors. This is a singleton that lives on the UI thread, with the 14 // report errors. This is a singleton that lives on the UI thread, with the
16 // exception of ReportError() which may be called from any thread. 15 // exception of ReportError() which may be called from any thread.
17 // TODO(aa): Hook this up to about:extensions, when we have about:extensions. 16 // TODO(aa): Hook this up to about:extensions, when we have about:extensions.
18 // TODO(aa): Consider exposing directly, or via a helper, to the renderer 17 // TODO(aa): Consider exposing directly, or via a helper, to the renderer
19 // process and plumbing the errors out to the browser. 18 // process and plumbing the errors out to the browser.
20 // TODO(aa): Add ReportError(extension_id, message, be_noisy), so that we can 19 // TODO(aa): Add ReportError(extension_id, message, be_noisy), so that we can
21 // report errors that are specific to a particular extension. 20 // report errors that are specific to a particular extension.
22 class ExtensionErrorReporter { 21 class ExtensionErrorReporter {
(...skipping 19 matching lines...) Expand all
42 static ExtensionErrorReporter* instance_; 41 static ExtensionErrorReporter* instance_;
43 42
44 ExtensionErrorReporter(bool enable_noisy_errors); 43 ExtensionErrorReporter(bool enable_noisy_errors);
45 44
46 MessageLoop* ui_loop_; 45 MessageLoop* ui_loop_;
47 std::vector<std::string> errors_; 46 std::vector<std::string> errors_;
48 bool enable_noisy_errors_; 47 bool enable_noisy_errors_;
49 }; 48 };
50 49
51 #endif // CHROME_BROWSER_EXTENSIONS_ERROR_REPORTER_H_ 50 #endif // CHROME_BROWSER_EXTENSIONS_ERROR_REPORTER_H_
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/bookmark_service.h ('k') | chrome/browser/gears_integration.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698