Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 481009: Add a simple microbenchmark framework, packaging, and sample tests. (Closed)

Created:
11 years ago by Will Drewry
Modified:
9 years, 7 months ago
Reviewers:
ericli
CC:
chromium-os-reviews_googlegroups.com, Chris Masone, kdlucas
Visibility:
Public.

Description

Add a simple microbenchmark framework, packaging, and sample tests. I have no idea if this is useful, but it works for me and might be useful if you have specific functions to test. No effort has been made to make it pretty or ensure statistical relevance.

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix the bad comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -0 lines) Patch
A src/platform/microbenchmark/SConstruct View 1 chunk +25 lines, -0 lines 0 comments Download
A src/platform/microbenchmark/benchmarks/getpid.cc View 1 chunk +19 lines, -0 lines 0 comments Download
A src/platform/microbenchmark/benchmarks/readwrite.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download
A src/platform/microbenchmark/debian/changelog View 1 chunk +5 lines, -0 lines 0 comments Download
A src/platform/microbenchmark/debian/compat View 1 chunk +1 line, -0 lines 0 comments Download
A src/platform/microbenchmark/debian/control View 1 chunk +18 lines, -0 lines 0 comments Download
A src/platform/microbenchmark/debian/rules View 1 chunk +52 lines, -0 lines 0 comments Download
A src/platform/microbenchmark/main.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A src/platform/microbenchmark/make_pkg.sh View 1 chunk +14 lines, -0 lines 0 comments Download
A src/platform/microbenchmark/microbenchmark.h View 1 chunk +101 lines, -0 lines 0 comments Download
A src/platform/microbenchmark/microbenchmark.cc View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Will Drewry
Any thoughts, review, etc are appreciated. I just needed something I could hack on quickly ...
11 years ago (2009-12-10 00:02:39 UTC) #1
ericli
LTGM. With a minor typerr. On 2009/12/10 00:02:39, wad wrote: > Any thoughts, review, etc ...
11 years ago (2009-12-10 01:12:29 UTC) #2
ericli
http://codereview.chromium.org/481009/diff/1/4 File src/platform/microbenchmark/benchmarks/readwrite.cc (right): http://codereview.chromium.org/481009/diff/1/4#newcode6 src/platform/microbenchmark/benchmarks/readwrite.cc:6: // Microbenchmark of getpid() getpid()?
11 years ago (2009-12-10 01:12:49 UTC) #3
Will Drewry
11 years ago (2009-12-10 01:22:06 UTC) #4
Thanks! Fixed.
--
I'll submit this then and investigate some of the open source alternatives that
have been suggested (like libmicro).

However, for a full suite, we might just stuck with autotest+unixbench :)s

http://codereview.chromium.org/481009/diff/1/4
File src/platform/microbenchmark/benchmarks/readwrite.cc (right):

http://codereview.chromium.org/481009/diff/1/4#newcode6
src/platform/microbenchmark/benchmarks/readwrite.cc:6: // Microbenchmark of
getpid()
On 2009/12/10 01:12:50, ericli wrote:
> getpid()?

Done.

Powered by Google App Engine
This is Rietveld 408576698