Issue 481001: Re-enable the build of Pepper support by default (issue 464074, svn revision ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 481001: Re-enable the build of Pepper support by default (issue 464074, svn revision ... (Closed)

Created:
11 years ago by sehr (please use chromium)

Modified:
9 years, 7 months ago

Reviewers:
apatrick, brettw, jam

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Re-enable the build of Pepper support by default (issue 464074, svn revision 34161). There were problems building Skia and others for the 64-bit linux versions of the Pepper test plugin, so I have disabled building that plugin except on Windows for now and added a TODO. One significant addition to the previous comment lines. The flag enable_gpu=1 now causes the build definition ENABLE_GPU=1 to allow guarding of dependent code. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34227

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -54 lines)			Patch
M	build/all.gyp	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
M	build/common.gypi	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View		2 chunks	+20 lines, -12 lines	0 comments	Download
M	webkit/glue/plugins/npapi_extension_thunk.cc	View		2 chunks	+0 lines, -17 lines	0 comments	Download
M	webkit/glue/plugins/plugin_host.cc	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	webkit/glue/webplugin.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/README	View		1 chunk	+2 lines, -8 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/event_handler.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages

Issue 481001: Re-enable the build of Pepper support by default (issue 464074, svn revision ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages