Issue 4810002: NaCl: Remove second variant of MakeSharedMemorySegmentViaIPC()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4810002: NaCl: Remove second variant of MakeSharedMemorySegmentViaIPC() (Closed)

Created:
10 years, 1 month ago by Mark Seaborn

Modified:
9 years, 5 months ago

Reviewers:
sehr (please use chromium)

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

NaCl: Remove second variant of MakeSharedMemorySegmentViaIPC() This was needed because the native_client tree referred to this function directly and #included renderer_sandbox_support_linux.h, but this direct reference has now been removed. BUG=http://code.google.com/p/nativeclient/issues/detail?id=469 TEST=NaCl's test_runner.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66441

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -12 lines)			Patch
M	chrome/nacl/nacl_thread.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_process_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_sandbox_support_linux.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/renderer/renderer_sandbox_support_linux.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sehr (please use chromium)

10 years, 1 month ago (2010-11-15 16:27:50 UTC) #2

On 2010/11/12 14:37:02, Mark Seaborn wrote:

LGTM.

Expand Messages | Collapse Messages