chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 4808003: Fix Valgrind errors that occurred during testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 4808003: Fix Valgrind errors that occurred during testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Already delete the URLFetcher object. Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/client_side_detection_service.cc ('K') | « chrome/browser/safe_browsing/client_side_detection_service.cc ('k') | tools/heapcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index b9d6c44014304d1418d6ed5c51bfed39bf28369b..ce5e205575077fb8c3449ec3498256a1d4f50b44 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -161,6 +161,7 @@ TEST_F(ClientSideDetectionServiceTest, SendClientReportPhishingRequest) {

// Valid thumbnail but the server returns an error.

thumbnail.setConfig(SkBitmap::kARGB_8888_Config, 100, 100);

ASSERT_TRUE(thumbnail.allocPixels());

+ thumbnail.eraseRGB(255, 0, 0);

SetClientReportPhishingResponse("", false /* fail */);

EXPECT_FALSE(SendClientReportPhishingRequest(url, score, thumbnail));