chrome/browser/safe_browsing/client_side_detection_service.h - Issue 4808003: Fix Valgrind errors that occurred during testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.h

Issue 4808003: Fix Valgrind errors that occurred during testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Already delete the URLFetcher object. Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/client_side_detection_service.h

diff --git a/chrome/browser/safe_browsing/client_side_detection_service.h b/chrome/browser/safe_browsing/client_side_detection_service.h

index 7b08fbb8702655e042bef9e6812036aa5f5a63bf..a0c72a9335b076caf7326943cd9a3c20c8efd4ba 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service.h

+++ b/chrome/browser/safe_browsing/client_side_detection_service.h

@@ -170,7 +170,7 @@ class ClientSideDetectionService : public URLFetcher::Delegate {

FilePath model_path_;

ModelStatus model_status_;

base::PlatformFile model_file_;

- scoped_ptr<URLFetcher> model_fetcher_;

+ URLFetcher* model_fetcher_;

scoped_ptr<std::string> tmp_model_string_;

std::vector<OpenModelDoneCallback*> open_callbacks_;