Fix Valgrind errors that occurred during testing.

Fix Valgrind errors that occurred during testing.

BUG=62943
TEST=ClientSideDetectionServiceTest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66157

[noelutz, 2010-11-12 22:03:06]

This should fix all the Valgrind errors.  At least it does on my machine.

Thanks,
noe.

[Brian Ryner, 2010-11-12 22:59:52]

It looks like you have a lot of changes for the heapcheck suppressions, is that
accidental?

http://codereview.chromium.org/4808003/diff/3001/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/client_side_detection_service.cc (right):

http://codereview.chromium.org/4808003/diff/3001/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/client_side_detection_service.cc:107: // The
fetcher object will be invalid after this method returns.x
extra trailing 'x'

[noelutz, 2010-11-12 23:34:13]

> It looks like you have a lot of changes for the heapcheck suppressions, is
that
> accidental?

Oups. This was a weird merging problem.  Fixed.

I'm new to Valgrind + Chrome.  With this CL if I run the following command I
don't get any warnings or errors anymore.

LD_LIBRARY_PATH=out/Debug/lib.target sh tools/valgrind/valgrind.sh
./out/Debug/unit_tests --gtest_filter=*ClientSideDetectionService*

Thanks,
noe.

[Brian Ryner, 2010-11-12 23:55:02]

LGTM

[Timur Iskhodzhanov, 2010-11-15 19:51:30]

LGTM

[Lei Zhang, 2010-11-16 08:29:01]

Sadly, Chromium Valgrind Mac still complains about these tests. There's way too
many errors to suppress. Many of them are in the test teardown. Perhaps you
should call msg_loop_.RunAllPending() first before destroying |csd_service_|?

[lzheng1, 2010-11-16 17:37:45]

See bug:
http://code.google.com/p/chromium/issues/detail?id=63328<http://code.google.c...

On Tue, Nov 16, 2010 at 12:29 AM, <thestig@chromium.org> wrote:

> Sadly, Chromium Valgrind Mac still complains about these tests. There's way
> too
> many errors to suppress. Many of them are in the test teardown. Perhaps you
> should call msg_loop_.RunAllPending() first before destroying
> |csd_service_|?
>
>
> http://codereview.chromium.org/4808003/
>