Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 48060: SSLPolicy Fix: Step 7.... (Closed)

Created:
11 years, 9 months ago by abarth-chromium
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

SSLPolicy Fix: Step 7. Simplify SSLPolicy to prepare for changing its algorithm. This change should not change the SSLPolicy behavior at all. R=jcampan BUG=8706 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11892

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -259 lines) Patch
M chrome/browser/ssl/ssl_policy.h View 1 4 chunks +14 lines, -19 lines 0 comments Download
M chrome/browser/ssl/ssl_policy.cc View 2 chunks +85 lines, -240 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
11 years, 9 months ago (2009-03-17 10:41:08 UTC) #1
abarth-chromium
11 years, 9 months ago (2009-03-17 17:37:19 UTC) #2
jcampan
LGTM http://codereview.chromium.org/48060/diff/1/3 File chrome/browser/ssl/ssl_policy.h (right): http://codereview.chromium.org/48060/diff/1/3#newcode5 Line 5: #ifndef CHROME_BROWSER_SSL_POLICY_H__ Since you are cleaning up ...
11 years, 9 months ago (2009-03-17 18:02:13 UTC) #3
abarth-chromium
11 years, 9 months ago (2009-03-17 18:07:25 UTC) #4
Thanks Jay.

http://codereview.chromium.org/48060/diff/1/3
File chrome/browser/ssl/ssl_policy.h (right):

http://codereview.chromium.org/48060/diff/1/3#newcode5
Line 5: #ifndef CHROME_BROWSER_SSL_POLICY_H__
Fixed.

Powered by Google App Engine
This is Rietveld 408576698