Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5072)

Unified Diff: chrome/browser/ssl/ssl_manager.h

Issue 48038: SSL Fix: Step 3.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/resource_request_details.h ('k') | chrome/browser/ssl/ssl_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_manager.h
===================================================================
--- chrome/browser/ssl/ssl_manager.h (revision 11701)
+++ chrome/browser/ssl/ssl_manager.h (working copy)
@@ -343,16 +343,17 @@
net::X509Certificate* cert,
MessageLoop* ui_loop);
- // Called when a mixed-content sub-resource request has been detected. The
- // request is not started yet. The SSLManager will make a decision on whether
- // to filter that request's content (with the filter_policy flag).
+ // Called before a URL request is about to be started. Returns false if the
+ // resource request should be delayed while we figure out what to do. We use
+ // this function as the entry point for our mixed content detection.
+ //
// TODO(jcampan): Implement a way to just cancel the request. This is not
// straight-forward as canceling a request that has not been started will
// not remove from the pending_requests_ of the ResourceDispatcherHost.
// Called on the IO thread.
- static void OnMixedContentRequest(ResourceDispatcherHost* resource_dispatcher,
- URLRequest* request,
- MessageLoop* ui_loop);
+ static bool ShouldStartRequest(ResourceDispatcherHost* resource_dispatcher,
+ URLRequest* request,
+ MessageLoop* ui_loop);
// Called by CertError::Dispatch to kick off processing of the cert error by
// the SSL manager. The error originated from the ResourceDispatcherHost.
« no previous file with comments | « chrome/browser/renderer_host/resource_request_details.h ('k') | chrome/browser/ssl/ssl_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698