Issue 48034: SSLPolicy Fix: Step 1....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48034: SSLPolicy Fix: Step 1.... (Closed)

Created:
11 years, 9 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

SSLPolicy Fix: Step 1. Expose some more accessors on WebFrame. R=wtc BUG=8706 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11838

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
M	webkit/glue/webframe.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/48034/diff/1/2 File webkit/glue/webframe_impl.cc (right): http://codereview.chromium.org/48034/diff/1/2#newcode694 Line 694: if (top) Can 'top' be NULL? The ...

11 years, 9 months ago (2009-03-16 23:36:05 UTC) #2

wtc

11 years, 9 months ago (2009-03-16 23:37:44 UTC) #3

http://codereview.chromium.org/48034/diff/1/2
File webkit/glue/webframe_impl.cc (right):

http://codereview.chromium.org/48034/diff/1/2#newcode772
Line 772: return "null";
One more question: Is "null" the right string to return
here?  Why don't you return an empty string?

Expand Messages | Collapse Messages