Clean up some more DEPS in chrome/common.

Clean up some more DEPS in chrome/common.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11787

[tony, 2009-03-16 20:26:17]

http://codereview.chromium.org/48024/diff/1/2
File chrome/common/ipc_message_macros.h (right):

http://codereview.chromium.org/48024/diff/1/2#newcode54
Line 54: // #include "chrome/common/ipc_sync_message_unittest.h"
Are you sure this will work?  I don't think this will pass the scons regex.  See
third_party/scons/scons-local/SCons/Scanner/C.py.

[Lei Zhang, 2009-03-16 21:44:46]

On 2009/03/16 20:26:17, tony wrote:
> http://codereview.chromium.org/48024/diff/1/2
> File chrome/common/ipc_message_macros.h (right):
> 
> http://codereview.chromium.org/48024/diff/1/2#newcode54
> Line 54: // #include "chrome/common/ipc_sync_message_unittest.h"
> Are you sure this will work?  I don't think this will pass the scons regex. 
See
> third_party/scons/scons-local/SCons/Scanner/C.py.

Looking at the regex in third_party/scons/scons-local/SCons/Scanner/C.py on line
125, that regex won't match "// #include ..." which is what we want, right?

[tony, 2009-03-16 21:55:04]

We want it to match these include lines.  See http://crbug.com/7828 which talks
about needing changes to those .h files to cause .cc files to rebuild.

On 2009/03/16 21:44:46, Lei Zhang wrote:
> On 2009/03/16 20:26:17, tony wrote:
> > http://codereview.chromium.org/48024/diff/1/2
> > File chrome/common/ipc_message_macros.h (right):
> > 
> > http://codereview.chromium.org/48024/diff/1/2#newcode54
> > Line 54: // #include "chrome/common/ipc_sync_message_unittest.h"
> > Are you sure this will work?  I don't think this will pass the scons regex. 
> See
> > third_party/scons/scons-local/SCons/Scanner/C.py.
> 
> Looking at the regex in third_party/scons/scons-local/SCons/Scanner/C.py on
line
> 125, that regex won't match "// #include ..." which is what we want, right?

[Lei Zhang, 2009-03-16 22:01:54]

Oh that looks awful. I excluded the changes to ipc_message_macros.h and added a
note about it in the DEPS file.

[tony, 2009-03-16 22:11:42]

LGTM!