Add targets for page_cycler_tests, perf_tests and startup_tests. Listed...

Add targets for page_cycler_tests, perf_tests and startup_tests.  Listed
minimal dependencies to build on Linux, Windows will need more.

Make a 'test_support_base' library containing the .cc files used
in common by perf tests in both net and chrome.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11803

[Mark Mentovai, 2009-03-16 20:08:23]

http://codereview.chromium.org/48021/diff/1/2
File chrome/chrome.gyp (right):

http://codereview.chromium.org/48021/diff/1/2#newcode1810
Line 1810: '../base/perftimer.cc',
lgtm as-is if it passes the try bots, but per our offline discussion here...

...it may be best to have base/base.gyp:test_support_perf, a target which
provides perftimer.cc and also has
'direct_dependent_settings':{'defines':['PERF_TEST']}.  This is similar to how
we push out the UNIT_TEST setting from testing/gtest.gyp:gtest.

[sgk, 2009-03-16 20:50:35]

Update from previous iteration:  put these targets in a !=mac condition.

[sgk, 2009-03-16 21:31:59]

Update update:  != mac for test_support_base, too.

[Mark Mentovai, 2009-03-16 21:35:08]

☠ needs work ☠

http://codereview.chromium.org/48021/diff/4/1006
File net/net.gyp (right):

http://codereview.chromium.org/48021/diff/4/1006#newcode463
Line 463: '../base/base.gyp:test_support_base',
This is going to break on the Mac, because you've made test_support_base
conditional on !mac.

[sgk, 2009-03-16 22:45:42]

http://build.chromium.org/buildbot/try-server/builders/mac/builds/5489
Whew!

[Mark Mentovai, 2009-03-16 23:14:05]

I think we have a winner.

✓ lgtm