Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 48009: Add thread information to the debugger (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
iposva, Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Add thread information to the debugger. Each thread running V8 code is assigned an id in thread local storage the first time V8 code is run in it. The thread information returned to the debugger contains the number of threads, the id of each of these threads and which one is the current thread. Added a threads command to the developer shell debugger for showing information on threads. Committed: http://code.google.com/p/v8/source/detail?r=1523

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -1 line) Patch
M src/d8.js View 3 chunks +24 lines, -0 lines 0 comments Download
M src/debug-delay.js View 3 chunks +28 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +72 lines, -0 lines 2 comments Download
M src/v8threads.h View 3 chunks +12 lines, -0 lines 0 comments Download
M src/v8threads.cc View 8 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-16 14:33:26 UTC) #1
Erik Corry
LGTM http://codereview.chromium.org/48009/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/48009/diff/1/2#newcode5778 Line 5778: // Check arguments. Wrong comment
11 years, 9 months ago (2009-03-17 09:44:12 UTC) #2
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-17 09:54:29 UTC) #3
http://codereview.chromium.org/48009/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/48009/diff/1/2#newcode5778
Line 5778: // Check arguments.
On 2009/03/17 09:44:13, Erik Corry wrote:
> Wrong comment

The comment is correct. All debugger runtime calls has the break id as the first
parameter which is checked by Runtime_CheckExecutionState. This is consistent
with all debugger runtime calls.

Powered by Google App Engine
This is Rietveld 408576698