Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: src/debug.h

Issue 48004: Changed preemption related stuff in debugger entry (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.h
===================================================================
--- src/debug.h (revision 1518)
+++ src/debug.h (working copy)
@@ -574,21 +574,11 @@
EnterDebugger()
: prev_(Debug::debugger_entry()),
has_js_frames_(!it_.done()) {
- ASSERT(!Debug::preemption_pending());
+ ASSERT(prev_ == NULL ? !Debug::preemption_pending() : true);
// Link recursive debugger entry.
Debug::set_debugger_entry(this);
- // If a preemption is pending when first entering the debugger clear it as
- // we don't want preemption happening while executing JavaScript in the
- // debugger. When recursively entering the debugger the preemption flag
- // cannot be set as this is disabled while in the debugger (see
- // RuntimePreempt).
- if (prev_ == NULL && StackGuard::IsPreempted()) {
- StackGuard::Continue(PREEMPT);
- }
- ASSERT(!StackGuard::IsPreempted());
-
// Store the previous break id and frame id.
break_id_ = Debug::break_id();
break_frame_id_ = Debug::break_frame_id();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698