Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 48001: Added more thread control to developer shell (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

The method yield is now available in the context created for threads in the developer shell. Added options --preemption/--no-preemption and --preemption-interval to control preemption in the developer shell when running several threads. Default is still to enable preemption with interval 1ms if threads are created. Committed: http://code.google.com/p/v8/source/detail?r=1518

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M src/d8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/d8.cc View 1 7 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-16 08:53:55 UTC) #1
Erik Corry
LGTM http://codereview.chromium.org/48001/diff/1/2 File src/d8.cc (right): http://codereview.chromium.org/48001/diff/1/2#newcode566 Line 566: preemption_interval = strtol(argv[++i], NULL, 10); I would ...
11 years, 9 months ago (2009-03-16 09:13:40 UTC) #2
Erik Corry
LGTM
11 years, 9 months ago (2009-03-16 09:47:31 UTC) #3
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-16 10:08:09 UTC) #4
http://codereview.chromium.org/48001/diff/1/2
File src/d8.cc (right):

http://codereview.chromium.org/48001/diff/1/2#newcode566
Line 566: preemption_interval = strtol(argv[++i], NULL, 10);
On 2009/03/16 09:13:41, Erik Corry wrote:
> I would really prefer it if this gave some indication to the user when parsing
> the integer failed.

Done.

Powered by Google App Engine
This is Rietveld 408576698