Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 4800001: Fix Chromium bug 62639. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix Chromium bug 62639. Add missing failure check after expecting an identifier in preparser. This allowed code to use the non-existing literal.

Patch Set 1 #

Patch Set 2 : Fix linto. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/preparser.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
10 years, 1 month ago (2010-11-11 09:20:39 UTC) #1
Mads Ager (chromium)
10 years, 1 month ago (2010-11-11 10:12:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698