Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 4798001: Add chrome revving module to crosutils (Closed)

Created:
10 years, 1 month ago by sosa
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, anush, sosa, Mandeep Singh Baines
Visibility:
Public.

Description

Add new chrome revving module to crosutils. Have subsequent review for cbuildbot that calls this for the pfq. This module has 3 modes ... TOT, latest_release, sticky_release that describe the three different types of revs for chrome we will be supporting. For tot, we grab the latest svn revision # from the chrome src tree, and rev to the corresponding ebuild i.e. 9.0.553.0_alpha-r1 with CROS_SVN_COMMIT=svn revision number. For latest_release, we grab the latest release from the releases page, and create an ebuild (or rev a previously existing on with same version) and use the release candidate suffix _rc. For sticky_release, we use much of the same logic as latest_release, however, we specifically look to rev _rc's in the sticky branch. This change depends on http://codereview.chromium.org/5172003 for the cros_mark_as_stable changes. Change-Id: Idc1f4cd905cc1dcb4c44422f6104760077a24b8d BUG=chromium-os:8693 TEST=Ran cros_mark_as_stable with --packages="chromeos-base/chromeos-chrome" --chrome_version=0.8.65.0 --chrome_revision=67890 commit. Re-ran unit-tests as well (though thinking about adding another unit test for chrome revving) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ed210b4

Patch Set 1 #

Patch Set 2 : Next upload #

Patch Set 3 : Uplload #

Patch Set 4 : Unit tests #

Patch Set 5 : Ran through gpylint #

Patch Set 6 : Remove cros_mark_stable stuff #

Total comments: 3

Patch Set 7 : Unittests!!! #

Patch Set 8 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+600 lines, -0 lines) Patch
A bin/cros_mark_chrome_as_stable View 1 chunk +1 line, -0 lines 0 comments Download
A bin/cros_mark_chrome_as_stable.py View 3 4 5 6 7 1 chunk +330 lines, -0 lines 0 comments Download
A bin/cros_mark_chrome_as_stable_unittest.py View 1 chunk +269 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sosa
10 years, 1 month ago (2010-11-11 03:53:18 UTC) #1
sosa
If you're interested, this is getting close. There is an issue with the EBuild class ...
10 years, 1 month ago (2010-11-17 21:25:51 UTC) #2
sosa
PTAL I have removed the cros_mark changes and put them in another CL and updated ...
10 years, 1 month ago (2010-11-18 00:48:41 UTC) #3
Chris Masone
http://codereview.chromium.org/4798001/diff/14001/bin/cros_mark_chrome_as_stable.py File bin/cros_mark_chrome_as_stable.py (right): http://codereview.chromium.org/4798001/diff/14001/bin/cros_mark_chrome_as_stable.py#newcode21 bin/cros_mark_chrome_as_stable.py:21: BASE_CHROME_SVN_URL = 'http://src.chromium.org/svn' This is only for the public ...
10 years, 1 month ago (2010-11-18 02:23:07 UTC) #4
Mandeep Singh Baines
http://codereview.chromium.org/4798001/diff/14001/bin/cros_mark_chrome_as_stable.py File bin/cros_mark_chrome_as_stable.py (right): http://codereview.chromium.org/4798001/diff/14001/bin/cros_mark_chrome_as_stable.py#newcode55 bin/cros_mark_chrome_as_stable.py:55: return line.split(':')[1].strip() On 2010/11/18 02:23:07, Chris Masone wrote: > ...
10 years, 1 month ago (2010-11-18 04:11:47 UTC) #5
Mandeep Singh Baines
On 2010/11/18 04:11:47, Mandeep Singh Baines wrote: > http://codereview.chromium.org/4798001/diff/14001/bin/cros_mark_chrome_as_stable.py > File bin/cros_mark_chrome_as_stable.py (right): > > ...
10 years, 1 month ago (2010-11-18 04:16:25 UTC) #6
Mandeep Singh Baines
Even better: $ man 1 svnversion $ svnversion 66511 msb@chromium.org (msb@chromium.org) wrote: > On 2010/11/18 ...
10 years, 1 month ago (2010-11-18 04:44:13 UTC) #7
Chris Masone
On 2010/11/18 04:44:13, Mandeep Singh Baines wrote: > Even better: > > $ man 1 ...
10 years, 1 month ago (2010-11-18 17:31:02 UTC) #8
Mandeep Singh Baines
cmasone@chromium.org (cmasone@chromium.org) wrote: > On 2010/11/18 04:44:13, Mandeep Singh Baines wrote: > >Even better: > ...
10 years, 1 month ago (2010-11-18 17:42:21 UTC) #9
sosa
Yeah I looked at using svnversion before doing the svn info work. The consensus of ...
10 years, 1 month ago (2010-11-18 18:33:41 UTC) #10
sosa
PTAL. Addressed svn revision and added unit tests.
10 years, 1 month ago (2010-11-19 16:45:57 UTC) #11
Chris Masone
10 years, 1 month ago (2010-11-19 18:48:59 UTC) #12
lgtm

Powered by Google App Engine
This is Rietveld 408576698