Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 479011: Scripts to use chrome as a login manager (Closed)

Created:
11 years ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Scripts to use chrome as a login manager. These are still prototypes, and without the right version of chrome will not work yet. When this code is active, the fundamental changes are as follows: 1) slim is no longer used 2) $HOME is now /home/chronos/user 3) Chrom[e|ium]'s --user-data-dir=/home/chronos 4) Chrom[e|ium]'s --profile=/home/chronos/user 5) We no longer have a way to specify a set of tabs to open the FIRST TIME a user logs in. Session restore still works. 6) login time is reduced, as we no longer need to wait to start Chrome until _after_ the user authenticates Temporary regressions: 1) Chrome tracks opting-in to stats collection on a per-user-data-dir level. Until this is per-profile, we can only opt into stats collection on a per-machine basis. As such, this disables stats collection when chrome is used as the login manager 2) The login manager window has normal window manager decorations on it, and can be dismissed by clicking on the close box. This needs to be addressed in the browser.

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixes per sosa comments #

Patch Set 3 : revert to /dev/urandom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -16 lines) Patch
A chromeos-chrome-login View 1 1 chunk +44 lines, -0 lines 0 comments Download
M debian/control View 1 chunk +1 line, -1 line 0 comments Download
M debian/dirs View 1 chunk +3 lines, -1 line 0 comments Download
M debian/rules View 2 chunks +4 lines, -3 lines 0 comments Download
M session_manager.sh View 2 1 chunk +6 lines, -6 lines 0 comments Download
M start_login.sh View 1 1 chunk +14 lines, -5 lines 0 comments Download
A start_wm.sh View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Masone
11 years ago (2009-12-09 22:42:41 UTC) #1
sosa
lgtm besides a few nits http://codereview.chromium.org/479011/diff/1/7 File start_login.sh (right): http://codereview.chromium.org/479011/diff/1/7#newcode18 start_login.sh:18: mkdir -p ${HOME} Do ...
11 years ago (2009-12-09 23:03:12 UTC) #2
Chris Masone
http://codereview.chromium.org/479011/diff/1/7 File start_login.sh (right): http://codereview.chromium.org/479011/diff/1/7#newcode18 start_login.sh:18: mkdir -p ${HOME} On 2009/12/09 23:03:12, sosa wrote: > ...
11 years ago (2009-12-10 00:31:55 UTC) #3
sosa
11 years ago (2009-12-10 00:34:51 UTC) #4
lgtm!

Powered by Google App Engine
This is Rietveld 408576698