Issue 479008: Implements bucket commands and adds unit tests to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 479008: Implements bucket commands and adds unit tests to... (Closed)

Created:
11 years ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implements bucket commands and adds unit tests to common_decoder TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34242

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+674 lines, -76 lines)			Patch
M	gpu/command_buffer/common/cmd_buffer_common.h	View		4 chunks	+51 lines, -37 lines	0 comments	Download
M	gpu/command_buffer/service/common_decoder.h	View	1	4 chunks	+76 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/common_decoder.cc	View		4 chunks	+128 lines, -22 lines	0 comments	Download
A	gpu/command_buffer/service/common_decoder_unittest.cc	View	1	1 chunk	+418 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		2 chunks	+0 lines, -16 lines	0 comments	Download
M	gpu/gpu.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick

11 years ago (2009-12-09 22:56:07 UTC) #2

I think you can fix the lint errors. Then LGTM.

http://codereview.chromium.org/479008/diff/1/4
File gpu/command_buffer/service/common_decoder.h (right):

http://codereview.chromium.org/479008/diff/1/4#newcode81
gpu/command_buffer/service/common_decoder.h:81: // Gets a pointer to a second of
the bucket. Returns NULL if
second->section?

Expand Messages | Collapse Messages